Codecov Report

❌ Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.17%. Comparing base (3a6f84f) to head (26e7498).
✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #2303      +/-   ##
==========================================
- Coverage   81.19%   81.17%   -0.03%     
==========================================
  Files          77       77              
  Lines        9738     9747       +9     
  Branches     1098     1100       +2     
==========================================
+ Hits         7907     7912       +5     
- Misses       1625     1628       +3     
- Partials      206      207       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

this will need tests update and thorough testing before merge

My $0.02: it should still be possible to manually specify UUID4s - to not break the case where pre-generated UUID4s are passed to signatures.

My $0.02: it should still be possible to manually specify UUID4s - to not break the case where pre-generated UUID4s are passed to signatures.

would you mind elaborate a bit more please? so that I can clearly understand what you wanted to be done here?

My $0.02: it should still be possible to manually specify UUID4s - to not break the case where pre-generated UUID4s are passed to signatures.

would you mind elaborate a bit more please? so that I can clearly understand what you wanted to be done here?

Sure:

This use case should not break:

import uuid

repositories.celery.infrastructure.celery_app.signature(
        result.name,
        immutable=task.immutable,
        args=result.args,
        kwargs=result.kwargs,
).set(task_id=str(uuid.uuid4()))  # <<< Notice this

OK, thanks a lot!

Found 1 test failure on Blacksmith runners:

Failure